Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow create/update OAuth2 DB #30071

Merged
merged 1 commit into from
Sep 3, 2024
Merged

feat: allow create/update OAuth2 DB #30071

merged 1 commit into from
Sep 3, 2024

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Aug 30, 2024 •
edited
Loading

SUMMARY

This PR is part of the work to add OAuth2 support for Snowflake. When creating the DB we provide only the OAuth2 client information (ID, secret, scope, auth/token URLs), which is not enough to test and validate the connection. We need to allow the DB to be created before the OAuth2 flow, so we can store the access tokens associated with a given DB.

Depends on #30067.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Added unit tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the api Related to the REST API label Aug 30, 2024
@betodealmeida betodealmeida force-pushed the create-oauth2-db branch 2 times, most recently from c436ac9 to 33ba31c Compare August 31, 2024 14:45
@betodealmeida betodealmeida marked this pull request as ready for review August 31, 2024 14:46
@dosubot dosubot bot added authentication Related to authentication data:connect Namespace | Anything related to db connections / integrations data:connect:snowflake Related to Snowflake labels Aug 31, 2024
@betodealmeida betodealmeida force-pushed the create-oauth2-db branch 2 times, most recently from 1cd7d5e to a95347a Compare August 31, 2024 15:05
@betodealmeida betodealmeida mentioned this pull request Aug 31, 2024
Merged
9 tasks
@sadpandajoe sadpandajoe requested a review from rtexelm September 3, 2024 18:51
rtexelm
rtexelm approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@rtexelm rtexelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betodealmeida betodealmeida changed the base branch from transaction-allowed-exceptions to master September 3, 2024 22:49
@betodealmeida betodealmeida merged commit 0415ed3 into master Sep 3, 2024
32 checks passed
@rusackas rusackas deleted the create-oauth2-db branch September 4, 2024 19:55
@betodealmeida betodealmeida mentioned this pull request Oct 31, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtexelm rtexelm rtexelm approved these changes

@eschutho eschutho Awaiting requested review from eschutho

Assignees
No one assigned
Labels
api Related to the REST API authentication Related to authentication data:connect:snowflake Related to Snowflake data:connect Namespace | Anything related to db connections / integrations preset-io size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@betodealmeida @rtexelm